Restore iptables at once using iptables-restore instead of calling iptables numerous times#1400
Closed
borisroman wants to merge 7 commits intoapache:4.7from
Closed
Restore iptables at once using iptables-restore instead of calling iptables numerous times#1400borisroman wants to merge 7 commits intoapache:4.7from
borisroman wants to merge 7 commits intoapache:4.7from
Conversation
Contributor
|
The integration tests succeed and this results in a massive speed improvement for ACL rules. We've tested it with 500 and 1000 and it's like 50-60 times faster. Result: And: Result: Now runs in our employee cloud, still testing and verifying beyond the integration tests. We should also investigate the Jenkins error. So far so good! |
| @@ -0,0 +1,227 @@ | |||
| #!/usr/bin/python | |||
Contributor
There was a problem hiding this comment.
this file needs a license header
Contributor
|
skimmed the code, looks good. I have some questions that might be answerred by a generic description of how this will improve performance. Could you add that @borisroman ? |
added 4 commits
February 5, 2016 12:02
…tables numerous times
borisroman
force-pushed
the
iptables-fix
branch
from
0f63846 to
eb9706b
Compare
Contributor
ACS CI BVT RunSumarry: The follwing tests have known issues Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 Failed tests:
Skipped tests: Passed test suits: |
asfgit
pushed a commit
that referenced
this pull request
May 18, 2016
Restore iptables at once using iptables-restore instead of calling iptables numerous timesThis makes handling the firewall rules about 50-60 times faster because it is generated in memory and then loaded once. It's work by @borisroman see PR #1400. Reopened it here because I think this is a great improvement. * pr/1482: Resolve conflict as forceencap is already in master Split the cidr lists so we won't hit the iptables-resture limits Check the existence of 'forceencap' parameter before use Do not load previous firewall rules as we replace everyhing anyway Wait for dnsmasq to finish restart Remove duplicate spaces, and thus duplicate rules. Restore iptables at once using iptables-restore instead of calling iptables numerous times Add iptables copnversion script. Signed-off-by: Will Stevens <williamstevens@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.